T1113606: Fix table attributors keyNames collision. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamvinogradov
requested review from
andrewmakarov and
gagharutyunyan1993
ksercs
reviewed
Dec 13, 2022
ksercs
reviewed
Dec 13, 2022
ksercs
reviewed
Dec 13, 2022
williamvinogradov
force-pushed
the
T1113606_1.6
branch
from
9631c8a to
27467cd
Compare
williamvinogradov
force-pushed
the
T1113606_1.6
branch
from
27467cd to
e5ab6ed
Compare
added 2 commits
December 14, 2022 02:43
Also, add some tests + code review fixes.
williamvinogradov
force-pushed
the
T1113606_1.6
branch
from
3b2a814 to
b9ea078
Compare
williamvinogradov
changed the title
Also, remove redundant class attributor + code review fixes + some little structure refactoring.
williamvinogradov
force-pushed
the
T1113606_1.6
branch
from
3e72fbf to
e402694
Compare
ksercs
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source ticket: T1113606
Implemented the new mechanism of separating table 'attributors' from the others.