fix(server-tests): errored tests after Node 15.3.0 update #5744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit 539bf94 have failed. See details: |
|
✅ Tests for the commit 539bf94 have passed. See details: |
2 similar comments
|
✅ Tests for the commit 539bf94 have passed. See details: |
|
✅ Tests for the commit 539bf94 have passed. See details: |
miherlosev
requested changes
Nov 26, 2020
Gulpfile.js
Outdated
| @@ -376,12 +376,42 @@ gulp.task('build', DEV_MODE ? gulp.registry().get('fast-build') : gulp.parallel( | |||
| // Test | |||
| gulp.step('prepare-tests', gulp.registry().get(SKIP_BUILD ? 'lint' : 'build')); | |||
|
|
|||
| function exitDomains () { | |||
There was a problem hiding this comment.
Move the exitDomains and enterDomains functions to the gulp/helpers/domain.js file.
Also add the !gulp statement to the .gitignore file - https://github.com/DevExpress/testcafe/pull/5724/files#diff-2f754321d62f08ba8392b9b168b83e24ea2852bb5d815d63e767f6c3d23c6ac5R3
miherlosev
approved these changes
Nov 26, 2020
|
✅ Tests for the commit 97a3d5d have passed. See details: |
1 similar comment
AndreyBelym
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume that Gulp's domain error handlers started to catch the unhandled promise rejections (placed in the tests for a reason) and interrupt test execution after "Unhandled rejections become errors on the domain" functionality shipped in Node 15.3.0. So, we need to bypass Gulp's error domains (using @AndreyBelym's hack).