aac-puml project infrastructure setup (#774) #1
Conversation
crazynewidea
assigned crazynewidea, lizzcondrey and bunchw and unassigned crazynewidea, lizzcondrey and bunchw
python/secure_install/README.md
Outdated
There was a problem hiding this comment.
So, I don't think it would get to go away fully because we still need to bundle the secure install components into the zip since that is something that gets provided for project hosting. But the steps that were previously producing the hash output that is now able to be accomplished with the build tool changes should get to be altered.
I believe it is outside of the scope of this task to fully determine what would have to change and how. Believe it is a solid candidate for a few tasks within the future pipeline refinement and buildtool modernization features.
Partially correct, while an upload-artifacts does occur in the Agree confirming the registration with PyPi is outside the scope of this task and code review, was just including it for SA. |
The |
There was a problem hiding this comment.
Good job getting version tags reassigned everywhere you had main, but it looks like you migrated versions and that can cause a lot of breakage with the actions within the workflows. Make sure you are using what is currently in core, we have an upcoming pipeline improvement feature that would tackle migrating action versions since that is well outside of the scope of the infrastructure task and the PUML feature.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Think this will be the last round. Looks like the action versions all got corrected, trusting the tweaks to the toml file being a result of something you're seeing since it is a new approach, and Gitpod launching seems to have been fixed since I can get it to launch now, and we were having issues with it yesterday.
| # # Python Dependencies | ||
| # ARG PYTHON_VERSION=3.9.13 | ||
|
|
||
| # RUN sudo add-apt-repository ppa:deadsnakes/ppa -y | ||
| # RUN sudo apt install python${PYTHON_VERSION} -y | ||
| # RUN sudo apt install python${PYTHON_VERSION}-venv -y | ||
| # RUN sudo update-alternatives --install /usr/bin/python3 python3 /usr/bin/python${PYTHON_VERSION} 2 | ||
| # RUN sudo pip install --upgrade pip |
There was a problem hiding this comment.
Why did these have to be commented out?
There was a problem hiding this comment.
they were causing the gitpod load to fail. This change made the gitpod load quicker and still accomplishes the python version load that we want. I left the commented out code there for reference in case we still wanted any of it. Is there something there you want to revive?
There was a problem hiding this comment.
Curious about why this was causing issues for you but not with the aac-spec repo. As long as you're tracking it as an issue and this is currently working, we can evaluate it as we continue to work in the repository and maintain what a rollback would look like with the commented section. This should be okay for now.
intermediate pull request to test main branch push workflow