This repository has been archived by the owner on Dec 20, 2022. It is now read-only.
Add docker tcp support #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,14 +57,19 @@ def run(): | |||
| parser.add_argument('action', help='The action to perform', choices=ACTIONS.keys()) | |||
| parser.add_argument('component_name', help='The name of the component to manage') | |||
| parser.add_argument('-m', dest='monitor', action='store_true', help='If specified and the action is "start" or "update", gantry will remain running to monitor components, auto restarting them as necessary') | |||
| parser.add_argument('--setconfig', dest='config_overrides', action='append', help='Configuration overrides for the component') | |||
| parser.add_argument('-o-setconfig', dest='config_overrides', action='append', help='Configuration overrides for the component') | |||
There was a problem hiding this comment.
Why the change of --setconfig?
There was a problem hiding this comment.
That was a typo, it's been removed.
|
@Shelnutt2: Should I re-review this? |
|
@josephschorr Yes this is ready for re-review. |
| if client is None: |
There was a problem hiding this comment.
Add a TODO to have this all moved into a class, as a global is a bit hacky
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the ability to specify the docker url, in order to support tcp connections. This is useful when combining gantry with docker swarm.