Limit maximum password length to 128 digits. #55
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit maximum password length to 128 digits.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
No limit on maximum password length.
Issue Number: DevToys-app/DevToys#1365
I just linked to the issue because it seems relevant, and I don't know if this fix addresses the content of the issue.
What is the new behavior?
Other information
Currently, there is no limit to the maximum length of a password, and any large number can be generated. In practice, however, if the password exceeds 10^6 digits, the application freezes.
The number of digits in the password is set to 128, which is close to the 127 digits supported by the Windows dialog.
Translated by DeepL
Quality check
Before creating this PR: