Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit maximum password length to 128 digits. #55

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

yui10
Copy link
Contributor

@yui10 yui10 commented Aug 21, 2024

Limit maximum password length to 128 digits.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

No limit on maximum password length.

Issue Number: DevToys-app/DevToys#1365

I just linked to the issue because it seems relevant, and I don't know if this fix addresses the content of the issue.

What is the new behavior?

  • Limit maximum password length to 128 digits.

Other information

Currently, there is no limit to the maximum length of a password, and any large number can be generated. In practice, however, if the password exceeds 10^6 digits, the application freezes.
The number of digits in the password is set to 128, which is close to the 127 digits supported by the Windows dialog.

Translated by DeepL

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler
Copy link
Collaborator

veler commented Aug 24, 2024

Hi,
This is awesome, thank you !

@veler veler merged commit a4035f0 into DevToys-app:main Aug 24, 2024
3 checks passed
@yui10 yui10 deleted the password-length-fix branch September 4, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants