Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix JWT expiration convert #58

Merged
merged 3 commits into from
Oct 20, 2024

Conversation

yui10
Copy link
Contributor

@yui10 yui10 commented Oct 8, 2024

Fixed remaining bug in date conversion process in "JsonWebTokenEncoderGuiTool.cs" .

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Application crashes when entering decimals in date and time.

Issue Number: N/A

What is the new behavior?

  • Changed from using Convert.ToInt32 to int.TryParse for date/time conversion.

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

In the `OnExpirationChanged` method, we changed it to convert `value` to an integer using `int.TryParse`.
@veler
Copy link
Collaborator

veler commented Oct 20, 2024

Hello,
Thank you for your contribution, and sorry for the very late review. This PR looks good to me!

@veler veler merged commit 58b5b25 into DevToys-app:main Oct 20, 2024
3 checks passed
@yui10 yui10 deleted the Bugfix-JWT-Expiration-Convert branch October 20, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants