Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Settings page internationalization and improved version number display #15

Merged
merged 2 commits into from
Oct 3, 2021

Conversation

veler
Copy link
Collaborator

@veler veler commented Oct 2, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe): Added more details to the way the app version is displayed.

What is the current behavior?

image

What is the new behavior?

image

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration

@veler veler requested a review from btiteux October 2, 2021 17:19
@btiteux btiteux merged commit 67c65f9 into main Oct 3, 2021
@btiteux btiteux deleted the versionDisplay branch October 3, 2021 16:08
veler added a commit that referenced this pull request Mar 31, 2023
…display (#15)

* Fixed Settings page internationalization and improved version number display

* Updated third party policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants