Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Monaco editor to DevToys #19

Merged
merged 20 commits into from
Oct 9, 2021
Merged

Added Monaco editor to DevToys #19

merged 20 commits into from
Oct 9, 2021

Conversation

veler
Copy link
Collaborator

@veler veler commented Oct 9, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

The text editor with line numbers suffer of several issues:

  • No syntax highlighting if the text editor isn't read only.
  • it doesn't scale with large texte of several thousand lines.

Issue Number: N/A

What is the new behavior?

  • We added the Monaco Editor
  • Monaco Editor can takes a few seconds to load because it's in a web view, but it's fast after.
  • Support of syntax highlighting even when typing.
  • Support of diff view
  • Better performances
  • Support of white spaces rendering
  • Support of extra features like Ctrl+F

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler added bug Something isn't working documentation Improvements or additions to documentation enhancement Idea of improvement of existing feature. labels Oct 9, 2021
@veler veler requested a review from btiteux October 9, 2021 18:23
@veler veler marked this pull request as ready for review October 9, 2021 18:34
@btiteux btiteux merged commit ecf8e37 into main Oct 9, 2021
@btiteux btiteux deleted the monaco-editor branch October 9, 2021 19:18
veler added a commit that referenced this pull request Mar 31, 2023
* Added Monaco Editor project and some of the required classes.

* backup

* Monaco editor builds!

* Monaco editor works!

* Monaco editor follows the UI theme

* Renamed CodeEditor to CodeEditorCore

* Added a CodeEditor user control to DevToys and use it in JsonFormatter

* Fixed an issue where JsonSerializer wouldn't be called in Release mode because .Net Native fails at resolving them through reflection.

* reverted unnecessary changes

* Removed Cascadia from shipped fonts. Instead, use whatever the installed font is by default.

* Removed pointerHandlerElement from CodeEditorCore

* Added a Render Whitespaces option.

* Fixed build issue

* Switched JsonYaml converter to Monaco Editor

* Added diff view to Monaco Editor. Changed the editor of Text Diff tool to support Diff View

* Removed TextEditor and FormattedTextBlock

* Fixed a bug with Paste button in Code Editor

* Fixed an issue where the Diff view wasn't read only

* give focus to editor after pasting

Co-authored-by: Etienne Baudoux <etbaudou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement Idea of improvement of existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants