Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HashGenerator output on base64 or hex #240

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

andrescirulo
Copy link
Contributor

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

The output of a hash generation is always Hex. Sometimes is useful for the output to be in base64.

Issue Number: #239

What is the new behavior?

  • An option to select the Output Type between Hex and Base64 has been added

@btiteux btiteux requested a review from veler January 28, 2022 07:06
Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for this contribution :)

@veler veler merged commit c7fc7ed into DevToys-app:main Jan 28, 2022
veler pushed a commit that referenced this pull request Mar 31, 2023
* HashGenerator output on base64 or hex

* Improved output type selected comparison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants