Fixing checksum comparison issue (#396) #406
Conversation
There was a problem hiding this comment.
Hello,
That's a simple, yet great addition! Thank you for this!
One thing I'd suggest though, the choice of color for the text doesn't work great in Light mode.
I'd suggest using an InfoBar, like in Number Base Converter.
You can also use the IsClosable property of this control to hide the close button at the right (I think it would make sense to not being able to close this information).
Even better, you could make the info bar yellow or red when the hash isn't matching, and green (Severity = Success) when it matches. What do you think about it?
|
Yeah, sure, I'm fixing that. I am not an experienced UWP developer, I didn't know such control exists, but definitely makes more sense. :) |
|
Screenshots of the modification: When hashes does not match: On light background: |
- Changes on the comparison evaluator method to support unit testing
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently, there is no visual indication of the comparison of outputs.
Issue Number: #396
What is the new behavior?
When the Output field and the Output Comparsion field both have value, then a text appears stating "The hashes are the same." or "The hashes are different.", whether the two fields have the same or different values.
Other information
Quality check
Before creating this PR, have you: