Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Simplified Chinese Translation of version 1.0.5 #467

Merged
merged 9 commits into from
Apr 3, 2022
Merged

Update Simplified Chinese Translation of version 1.0.5 #467

merged 9 commits into from
Apr 3, 2022

Conversation

Gaoyifei1011
Copy link
Contributor

@Gaoyifei1011 Gaoyifei1011 commented Mar 28, 2022

Update Simplified Chinese Translation of version 1.0.5

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

仅更新简体中文翻译版本
Only update Simplified Chinese Translation of version

Other information

一个小问题反馈
A little bug feedback
屏幕截图 2022-03-28 120532
请问您一下关于在Microsoft Store上架的正式版本,在简体中文版本的DevToys中。关于甚至界面语言选项中的两个重复的语言设置选项还没有解决吗
Please ask about the official version that is available on the Microsoft Store, in the Chinese Simplified version of DevToys. Regarding even the two duplicate language setting options in the interface language options have not been resolved
上一次在问题 #128 (comment) 中已经提到,那时的版本是0.x开发版本,但是现在的1.x版本好像还是没有解决。
As mentioned last time in the #128 (comment), the version at that time was the 0.x development version, but the current 1.x version still seems to have not been solved.

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler
Copy link
Collaborator

veler commented Mar 29, 2022

Hi,
Thank you for the update.
Regarding your comment on the listed languages, I keep using what Windows itself provides. I have trouble to understand how "wrong" it is. Can you please explain it again? 🤔

@Gaoyifei1011
Copy link
Contributor Author

Hi, Thank you for the update. Regarding your comment on the listed languages, I keep using what Windows itself provides. I have trouble to understand how "wrong" it is. Can you please explain it again? 🤔
image
就我个人而言,我认为这两个选项设置的界面语言是重复的,都是简体中文,并没有必要共同存在。而且在我安装的另外一款软件quickpad中,并没有同时出现这两个选项。
Personally, I think the interface language of these two options is the same, both simplified Chinese, and there is no need to exist together. And quickPad, the other software I installed, didn't have both options.

Copy link
Contributor

@YuhanKun YuhanKun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the English SearchKeywords so users can do quick searches without turning on the IME every time.

src/dev/impl/DevToys/Strings/zh-Hans/RegEx.resw Outdated Show resolved Hide resolved
src/dev/impl/DevToys/Strings/zh-Hans/Settings.resw Outdated Show resolved Hide resolved
src/dev/impl/DevToys/Strings/zh-Hans/SqlFormatter.resw Outdated Show resolved Hide resolved
src/dev/impl/DevToys/Strings/zh-Hans/TextDiff.resw Outdated Show resolved Hide resolved
src/dev/impl/DevToys/Strings/zh-Hans/Timestamp.resw Outdated Show resolved Hide resolved
Gaoyifei1011 and others added 7 commits March 31, 2022 19:32
Co-authored-by: Yuhan <NecromancyMaster@outlook.com>
Co-authored-by: Yuhan <NecromancyMaster@outlook.com>
Co-authored-by: Yuhan <NecromancyMaster@outlook.com>
Co-authored-by: Yuhan <NecromancyMaster@outlook.com>
Co-authored-by: Yuhan <NecromancyMaster@outlook.com>
Co-authored-by: Yuhan <NecromancyMaster@outlook.com>
Co-authored-by: Yuhan <NecromancyMaster@outlook.com>
@Gaoyifei1011
Copy link
Contributor Author

I think we should keep the English SearchKeywords so users can do quick searches without turning on the IME every time.

感谢您的参与与帮忙,我已经接受了您提出的更改
image

@veler
Copy link
Collaborator

veler commented Apr 3, 2022

uickpad中,并没有同时出现这两个选项。
Personally, I think the interface language of these two options is the same, both simplified Chinese, and there is no need to exist together. And quickPad, the other software I installed, didn't have both options.

Thanks for your answer. :)
I will merge the PR but we can continue this discussion. I think I will need to look at the QuickPad / Files code from @yaichenbaum ^^

@veler veler merged commit e9b5894 into DevToys-app:main Apr 3, 2022
@Gaoyifei1011
Copy link
Contributor Author

uickpad中,并没有同时出现这两个选项。
Personally, I think the interface language of these two options is the same, both simplified Chinese, and there is no need to exist together. And quickPad, the other software I installed, didn't have both options.

Thanks for your answer. :) I will merge the PR but we can continue this discussion. I think I will need to look at the QuickPad / Files code from @yaichenbaum ^^

好吧,关于这个问题,这也许可能是一个很有趣的问题。这个问题可能是一个很怪异且不容易被定位的bug。希望您未来有时间的话可以研究一下并解决一下这个BUG,谢谢您的回答
Well, that might be an interesting question about that. This problem can be a weird bug that is not easy to locate. I hope you can study and solve this BUG if you have time in the future. Thank you for your answer

veler pushed a commit that referenced this pull request Mar 31, 2023
* Update Simplified Chinese Translation of version 1.0.5

Update Simplified Chinese Translation of version 1.0.5

* Update src/dev/impl/DevToys/Strings/zh-Hans/ColorBlindnessSimulator.resw

Co-authored-by: Yuhan <NecromancyMaster@outlook.com>

* Update src/dev/impl/DevToys/Strings/zh-Hans/RegEx.resw

Co-authored-by: Yuhan <NecromancyMaster@outlook.com>

* Update src/dev/impl/DevToys/Strings/zh-Hans/SqlFormatter.resw

Co-authored-by: Yuhan <NecromancyMaster@outlook.com>

* Update src/dev/impl/DevToys/Strings/zh-Hans/NumberBaseConverter.resw

Co-authored-by: Yuhan <NecromancyMaster@outlook.com>

* Update src/dev/impl/DevToys/Strings/zh-Hans/Settings.resw

Co-authored-by: Yuhan <NecromancyMaster@outlook.com>

* Update src/dev/impl/DevToys/Strings/zh-Hans/TextDiff.resw

Co-authored-by: Yuhan <NecromancyMaster@outlook.com>

* Update src/dev/impl/DevToys/Strings/zh-Hans/Timestamp.resw

Co-authored-by: Yuhan <NecromancyMaster@outlook.com>

Co-authored-by: Yuhan <NecromancyMaster@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants