Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug with dark theme #51

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Fixed a bug with dark theme #51

merged 1 commit into from
Oct 29, 2021

Conversation

veler
Copy link
Collaborator

@veler veler commented Oct 29, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

image

Issue Number: #46

What is the new behavior?

Fixed this issue by using {ThemeResource} markup.

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler added the bug Something isn't working label Oct 29, 2021
@veler veler merged commit 8691677 into main Oct 29, 2021
@veler veler deleted the darkthemebug branch October 29, 2021 23:27
@veler veler linked an issue Oct 29, 2021 that may be closed by this pull request
veler added a commit that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark theme elements are broken
1 participant