Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Base64 Image Encoder / Decoder #519

Merged
merged 4 commits into from
May 14, 2022
Merged

Added Base64 Image Encoder / Decoder #519

merged 4 commits into from
May 14, 2022

Conversation

veler
Copy link
Collaborator

@veler veler commented May 14, 2022 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #285

What is the new behavior?

  • Added a Base64 Image Encoder / Decoder tool
  • Renamed Base64 Encoder / Decoder to Base64 Text Encoder / Decoder
  • Moved the ImagePreview control to the Controls folder and made it more reusable
  • Changed the CustomTextBox so we can have a Copy button even when the control isn't read only.

Other information

image

image

Note: This view loses a bit of functionality
image

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler linked an issue May 14, 2022 that may be closed by this pull request
Base64 <> Image Converter #285
Closed
@veler veler requested a review from btiteux May 14, 2022 00:45
@veler veler added the enhancement Idea of improvement of existing feature. label May 14, 2022
@veler veler merged commit a7e41ee into main May 14, 2022
@veler veler deleted the base64image branch May 14, 2022 15:57
@veler veler added this to the v1.0.7.0 milestone May 15, 2022
@lofcz
Copy link

lofcz commented May 24, 2022

Great feature, thanks!

veler added a commit that referenced this pull request Mar 31, 2023
@veler
Added Base64 Image Encoder / Decoder (#519)
d005e67 
* Added Base64 Image Encoder / Decoder

* Updated text box

* Updated languages

* Fixed unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btiteux btiteux Awaiting requested review from btiteux

Assignees
No one assigned
Labels
enhancement Idea of improvement of existing feature.
Projects
None yet
Milestone
v1.0.7.0
Development

Successfully merging this pull request may close these issues.

Base64 <> Image Converter
2 participants
@veler @lofcz