Fix JsonHelper.Format failing when deserializing top-level array objects #640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds appropriate test cases to JsonHelperTests
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Current behavior will deserialize the Input field of the JsonFormatter as a JObject, which will work as expected for top-level values and object definitions. But when the top-level object is an array, it cannot be serialized to this type, and instead writes the exception body to the Output.
Issue Number: #620
What is the new behavior?
The new behavior deserializes the Input text as a JToken, which is able to represent both JObject and JArray types. To handle sorting properties recursively, I created an overload of JsonFormatter.SortJsonPropertiesAlphabetically for JArray objects. Both methods were modified to recursively call eachother based on the property's JToken type.
Other information
Quality check
Before creating this PR, have you: