Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to Angular 15 and GrapesJS to 0.21.1 #17

Merged
merged 1 commit into from
Apr 27, 2023
Merged

upgrade to Angular 15 and GrapesJS to 0.21.1 #17

merged 1 commit into from
Apr 27, 2023

Conversation

iklimisdev
Copy link
Collaborator

No description provided.

@bampakoa
Copy link
Member

I tried to run the local demo application and when I select Webpage editor mode I get the following message in the browser console:

core.mjs:8416 ERROR TypeError: Cannot set property defaults of [object Object] which has only a getter
    at node_modules\grapesjs\dist\grapes.min.js:2:347571
    at Module.Vt (node_modules\grapesjs\dist\grapes.min.js:2:347800)
    at Function.q [as extend] (node_modules\grapesjs\dist\grapes.min.js:2:30116)
    at t.default (node_modules\grapesjs-preset-webpage\dist\grapesjs-preset-webpage.min.js:4:6149)
    at node_modules\grapesjs-preset-webpage\dist\grapesjs-preset-webpage.min.js:4:1383
    at node_modules\grapesjs-preset-webpage\dist\grapesjs-preset-webpage.min.js:2:3371
    at node_modules\grapesjs\dist\grapes.min.js:2:943400
    at Array.forEach (<anonymous>)
    at Object.init (node_modules\grapesjs\dist\grapes.min.js:2:943235)
    at NgxWebpageEditorComponent.setup (editor.component.ts:26:21)

@iklimisdev iklimisdev force-pushed the angular-and-grapesjs-upgrade branch from 39e1ff7 to 2f50797 Compare April 26, 2023 09:22
@iklimisdev iklimisdev changed the title upgrade to Angular v15 ang GrapesJS v0.20.4 upgrade to Angular 15 and GrapesJS to 0.21.1 Apr 26, 2023
@iklimisdev
Copy link
Collaborator Author

@bampakoa I bumped GrapesJs to the latest alongside with the codependent libraries

@iklimisdev iklimisdev requested a review from bampakoa April 26, 2023 09:27
bampakoa
bampakoa requested changes Apr 26, 2023
View reviewed changes
projects/ngx-grapesjs/schematics/ng-add/index.ts Show resolved Hide resolved
projects/ngx-grapesjs/schematics/ng-add/index.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@iklimisdev iklimisdev force-pushed the angular-and-grapesjs-upgrade branch from 2f50797 to 3725a80 Compare April 27, 2023 08:12
@iklimisdev iklimisdev requested a review from bampakoa April 27, 2023 08:13
bampakoa
bampakoa approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@bampakoa bampakoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍 Thanks for addressing my feedback 🙏

@bampakoa bampakoa merged commit b65c587 into master Apr 27, 2023
@bampakoa bampakoa deleted the angular-and-grapesjs-upgrade branch April 27, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bampakoa bampakoa bampakoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iklimisdev @bampakoa