-
Notifications
You must be signed in to change notification settings - Fork 2k
Support for Bitfinex API #2
Comments
I will add other exchanges if the demand is there. however each exchange/pair needs to be machine-learned separately and I don't use Bitfinex so I'd rely on other users to submit bug reports. |
Perhaps you have seen the news on twitter that coinbase/gdax may be insolvent. I would vote for bitfinex and/or poloniex trading to be added. Also, it is possible to add margin trading (with the ability to have the bot short?) |
zenbot 3.x is going to be based on a new lib zenbrain which exposes a plugin API for all bot tasks. This includes
Bitfinex support will be included, but a problem arises of trying to backfill Bitfinex trades. So far I haven't found a way to get access to their historical trade API, when using an old timestamp it just gives recent trades instead, as if there's an artificial limit on how old you can query. Anyway I definitely want to include support for all major exchanges that have open APIs. |
Badly needed Bitfinex trading API. |
Any way you could substitute the data set from another source to backfill historical data for bitfinex? I'm also here to say "Support for Bitfinex +1" I'll help where ever I can to help support it. |
Support for Bitfinex +1 |
http://docs.bitfinex.com/v1/reference#rest-public-trades limit_trades default 50 and I found maximum 49999 |
I have made a branch for Bitfinex support. Now it's collecting history/backfilling/running sim, but I did not made it to trade yet. https://github.com/nedievas/zenbot |
Love it - Awesome work! Any idea on how to back fill data from Bitfinex rather than let it collect data? |
I'll try to update files this weekend. It's already backfilling the data. I'm trying to get it real trading. |
I have tried installing yet have issue finding the config.js file. I have done that but not sure about the issue. [ec2-user@ip-10-0-0-12 zenbot]$ ./run.sh Error: No config found. Please copy config_sample.js to config.js, edit, and re-try. |
@cloudwaves - Did you even read what the output said? Did you figure you'd just copy and paste it here for us to hold your hand? Read other threads, this has been covered a few different times... The hint I'll give you....
|
Hi, I have mentioned that I have already done that! I have already copied config_sample.js to config.js. the config.js is present in /home/ec2-user/zenbot/config.js |
Here is the list of file in zenbot folder. drwxrwxr-x 3 ec2-user ec2-user 4096 Mar 13 08:54 assets |
made a fresh clone. [bfxbot@gene zenbot]$ ./run.sh everything seems to work. |
Confirmed working over here as well. Try making a fresh copy of it? It doesn't seem to be your permissions either, those look to be correct. Are there any additional spaces anywhere? As a relevant update. I almost have all historical information imported into Mongo correctly. Will release script when complete. 💯 |
@OpenSourceMasta Yeah, Now I have removed zenbot folder and cloned newly. [ec2-user@ip-10-0-0-6 ~]$ git clone https://github.com/nedievas/zenbot.git Error: No config found. Please copy config_sample.js to config.js, edit, and re-try. But if I clone from https://github.com/carlos8f/zenbot.git, it working without any issue. Since I don't have GDAX account, I cannot use that... If you want to test, please PM me to spicepearls(at)gmail(dot)com. |
Don't know if it matters. I try to reproduce your error again:
Please check if everything matches. |
What is your OS? I am doing exactly the same. Hear is my installation log.
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR micro-request@666.0.8 node_modules/micro-request zero-fill@2.2.3 node_modules/zero-fill object-get@2.1.0 node_modules/object-get run-parallel-limit@1.0.3 node_modules/run-parallel-limit run-parallel@1.1.6 node_modules/run-parallel colors@1.1.2 node_modules/colors ansi_up@1.3.0 node_modules/ansi_up commander@2.9.0 node_modules/commander multi-progress@2.0.0 node_modules/multi-progress sig@1.0.0 node_modules/sig moment-timezone@0.5.11 node_modules/moment-timezone os-monitor@1.0.5 node_modules/os-monitor numbro@1.8.1 node_modules/numbro axios@0.13.1 node_modules/axios timebucket@0.3.4 node_modules/timebucket motley@2.2.8 node_modules/motley motley-mongo@2.0.5 node_modules/motley-mongo motley-buffet@2.0.2 node_modules/motley-buffet kraken-api@0.1.7 node_modules/kraken-api bitfinex-api-node@0.2.9 node_modules/bitfinex-api-node twit@2.2.5 node_modules/twit coinbase-exchange@0.2.1 node_modules/coinbase-exchange motley-templ@2.0.4 node_modules/motley-templ moment@2.17.1 node_modules/moment zenbrain@1.0.0-alpha node_modules/zenbrain |
Linux gene.birt 4.9.13-200.fc25.x86_64 #1 SMP Mon Feb 27 16:48:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
can you please PM me? we shall try in AWS? I don't have Virtual Box installed in my machine to install other linux versions rather then available in AWS (RHEL, SUSE, UBUNTU, AMAZON Linux)! (NOT ALLOWED IN OFFICE) :( |
Finally it got worked in Redhat Linux from AWS. Below steps are I have followed.
|
Live Graph has No Data :( Also I just run to see the backtest Still the URL has No Data:( |
That's because you have to backfill before backtesting. |
I am not sure I am running it correctly to backfill! Command
with default bitfinex_logic.js was the trading profitable? how much BTC I need to run the trade ? |
Zenbot 4 is out, so I'm cleaning up 3.x issues. Please use and test 4, thanks! |
Implement working dir as variable editable in conf.
node-gyp and node v8.x are not friends, stick to boron for now Rename talib's MACD (#2) * Rename talib's MACD so it doesn't overlap with original macd
node-gyp and node v8.x are not friends, stick to boron for now Rename talib's MACD (DeviaVir#2) * Rename talib's MACD so it doesn't overlap with original macd
With deposit set order would be below minimum with asset on hold
* Completely rework --buy_max_amt As much as i like the --buy_max_amt feature i was never a fan of how it was implemented, leave alone the naming being confusing at best as it simply doesn't just account for the amount the bot can buy but how much he is actually able to trade. * Renames --buy_max_amt to --deposit for sake of clarification * Using --buy_max_amt will still work but print a deprecated warning * Instead of using --deposit to size buy orders use it to limit the balance available to the bot * This allows us to use it together with --buy_pct * --deposit will still account for asset held to calculate the available currency balance * So if the asset held is covering --deposit the bot will have 0 currency (0% of currency balance) available, if not currency will be filled to the point it compensates for the difference (up to 100% of currency balance) * If deposit is exceeding asset + currency the bot will also use 100% of currency balance held * Deposit will be updated on each price change and new period to ensure the bot always only trades the amount as defined by --deposit * Profit calculation will no longer go havoc as long as currency balance doesn't fall below whats currently deposited into the bot * If enabled this will add two new columns to the output displaying the total currency balance (in green) as well as how much percentage (gray) of currency balance (0 - 100%) is currently used by the bot * Works in Live, Paper & Sim mode * Profit * Fix profit calculation for stats and API * Add deposit to Web GUI's capital row * Profit starts at 100% on reset * WebUI Print deposit only if enabled * Add deposit to sim/exchange * Less invasive profit fix * Use deposit for profit/stats in sim if enabled * Remove prev_trades dashboard sorting * Restore prev_trades dashboard sorting * Resolve upstream conflicts * Update engine.test to match changes As deposit no longer overrides buy_pct this is kinda expected... * Update engine.test to match changes #2 With deposit set order would be below minimum with asset on hold * Reset profit on deposit change
It would be really useful to add support for bitfinex trading API.
I've never used NodeJS before, but I'll see if I can help.
The text was updated successfully, but these errors were encountered: