4.1.3

.env-sample

@@ -0,0 +1,5 @@
+BASIC_AUTH_ZEN=ommm:$apr1$1n0zqO2y$A2ueB9zMWZTYTtfckFhql1
+TRAEFIK_HOST_ZEN=myhost.com
+BASIC_AUTH_DB=ommm:$apr1$1n0zqO2y$A2ueB9zMWZTYTtfckFhql1
+TRAEFIK_HOST_DB=db.myhost.com
+TRAEFIK_NETWORK_NAME=traefik-proxy

.gitignore

@@ -37,4 +37,6 @@ dist/*
 simulations/sim_*.json
 gen.*.bat
 gen.*.sh
-
+.env
+scripts/auto_backtester/backtesting_*.csv
+database/*

Dockerfile

@@ -1,15 +1,21 @@
-FROM node:8
-
-RUN mkdir -p /app
+FROM node:8 as builder
+ADD . /app
 WORKDIR /app
-
-COPY . /app
 RUN npm install -g node-gyp
 RUN npm install --unsafe
 
+FROM node:8-alpine
+
+ADD . /app
+WORKDIR /app
+
+COPY --from=builder /usr/local/lib/node_modules/ /usr/local/lib/node_modules/
+COPY --from=builder /app/node_modules /app/node_modules/
+COPY --from=builder /app/dist /app/dist/
+
 RUN ln -s /app/zenbot.sh /usr/local/bin/zenbot
 
 ENV NODE_ENV production
 
-ENTRYPOINT ["/usr/local/bin/node", "zenbot.js"]
+ENTRYPOINT ["/app/zenbot.sh"]
 CMD [ "trade", "--paper" ]

Makefile

@@ -0,0 +1,132 @@
+# Check if this is Windows
+ifneq (,$(findstring WINDOWS,$(PATH)))
+WINDOWS := True
+endif
+
+# Set shell to cmd on windows
+ifdef WINDOWS
+SHELL := C:/Windows/System32/cmd.exe
+endif
+
+# Don't use sudo on windows
+SUDO := "sudo"
+ifdef WINDOWS
+SUDO := 
+endif
+
+# set home dir to user's home on windows running MINGW
+ifdef MSYSTEM
+HOME := $(subst \,/,$(HOME))
+endif
+
+# Get the root dir of this file
+ROOT_DIR := $(shell dirname $(realpath $(lastword $(MAKEFILE_LIST))))
+
+# Define the full path to this file
+THIS_FILE := $(lastword $(MAKEFILE_LIST))
+
+# Set docker-compose file selector for windows
+ifneq (,$(findstring WINDOWS,$(PATH)))
+DC_CONFIG=$(ROOT_DIR)/docker-compose-windows.yml
+else
+DC_CONFIG=$(ROOT_DIR)/docker-compose.yml
+endif
+
+# Find or create a home for sensitive environment variables
+# Check my secret place
+CREDS=$(HOME)/.bash/.credentials
+ifneq ("$(wildcard $(CREDS))","")
+CREDENTIALS := $(CREDS)
+else
+# Check a normal place
+CREDS=$(HOME)/.credentials
+ifneq ("$(wildcard $(CREDS))","")
+CREDENTIALS := $(CREDS)
+else
+$(info $(shell "mkdir" $(CREDS)))
+endif
+endif
+
+# To use arguments with make execute: make -- <command> <args>
+ARGS = $(filter-out $@,$(MAKECMDGOALS))
+MAKEFLAGS += --silent
+
+list:
+	sh -c "echo; $(MAKE) -p no_targets__ | awk -F':' '/^[a-zA-Z0-9][^\$$#\/\\t=]*:([^=]|$$)/ {split(\$$1,A,/ /);for(i in A)print A[i]}' | grep -v '__\$$' | grep -v 'Makefile'| sort"
+
+#############################
+# ZENBOT
+#############################
+
+list-strategies:
+	docker-compose exec server zenbot list-strategies $(ARGS)
+
+list-selectors:
+	docker-compose exec server zenbot list-selectors $(ARGS)
+
+backfill:
+	docker-compose exec server zenbot backfill $(ARGS)
+
+sim:
+	docker-compose exec server zenbot sim $(ARGS)
+
+trade:
+	docker-compose exec server zenbot trade $(ARGS)
+
+paper:
+	docker-compose exec server zenbot trade --paper $(ARGS)
+
+balance:
+	docker-compose exec server zenbot balance $(ARGS)
+
+buy:
+	docker-compose exec server zenbot buy $(ARGS)
+
+sell:
+	docker-compose exec server zenbot sell $(ARGS)
+
+zenbot:
+	docker-compose exec server zenbot $(ARGS)
+
+#############################
+# Docker machine states
+#############################
+time-sync:
+	docker run --rm --privileged alpine hwclock -s
+
+up:
+	$(SUDO) docker-compose --file=$(DC_CONFIG) up
+
+start:
+	docker-compose start
+
+stop:
+	docker-compose stop
+
+state:
+	docker-compose ps
+
+rebuild:
+	$(SUDO) docker-compose stop
+	$(SUDO) docker-compose pull
+	$(SUDO) docker-compose rm --force server
+	$(SUDO) docker-compose rm --force mongodb
+	-$(SUDO) docker-compose rm --force adminmongo
+	$(SUDO) docker-compose build --no-cache
+	$(SUDO) docker-compose --file=$(DC_CONFIG) up -d --force-recreate
+
+
+shell:
+	docker-compose exec server /bin/sh
+
+shellw:
+	docker exec -it -u root $$(docker-compose ps -q server) /bin/sh
+
+logs:
+	docker-compose logs $(ARGS)
+
+#############################
+# Argument fix workaround
+#############################
+%:
+	@:

README.md

@@ -5,20 +5,8 @@
 
 # Zenbot [![Build/Test Status](https://travis-ci.org/DeviaVir/zenbot.svg?branch=master)](https://travis-ci.org/DeviaVir/zenbot) [![Greenkeeper badge](https://badges.greenkeeper.io/DeviaVir/zenbot.svg)](https://greenkeeper.io/)
 
-## Current Status
-
-Zenbot 4 is functional, but is having trouble reliably making profit. At this point, **I would recommend against trading with large amounts** until some of these issues can be worked out:
-
-- Many people are reporting [losses in live trading](https://github.com/carlos8f/zenbot/issues/189) even if the simulation results and/or paper trading is positive.
-- This is my highest priority right now, since an unprofitable bot is not worth much, but please understand that reliably making profit is hard, and so is making a realistic simulator.
-- The losses may be due to the default strategy not working well in sideways (non-trending) market conditions, slippage during limit order execution, or both. Currently I would recommend against using Zenbot on a market that is non-trending or trending generally downwards.
-- The limit-order strategy that Zenbot uses to avoid taker fees, is prone to race conditions and delays. A mode for using market-type orders will probably need to be made, which may make frequent-trade strategies less viable due to fees, but more reliable execution overall.
-- An upcoming feature will allow Zenbot to use a limited amount of your balance, which will help with experimenting with live trading, but mitigating the possible losses from the issues above.
-
-Zenbot is a hobby project for me and I'm sorry that I can't devote myself full-time to it. Since I'm getting busier, development may slow down a bit from here, so please be patient if issues aren't fixed right away.
-
 ## Questions
-Please ask (programming) questions related to zenbot on stackoverflow. The tag is [zenbot](https://stackoverflow.com/questions/tagged/zenbot).
+Please ask (programming) questions related to zenbot on reddit. The subreddit is [zenbot](https://reddit.com/r/zenbot).
 
 ## Description
 
@@ -76,7 +64,7 @@ cp conf-sample.js conf.js
 - View and edit `conf.js`.
 - It's possible to use zenbot in "paper trading" mode without making any changes.
 - You must add your exchange API keys to enable real trading however.
-- API keys do NOT need deposit/withdrawl permissions.
+- API keys do NOT need deposit/withdrawal permissions.
 
 If using Docker, skip to section "Docker" below.
 
@@ -818,12 +806,6 @@ Or to sell 10% of your BTC,
 zenbot sell gdax.BTC-USD --pct=10
 ```
 
-## Chat with other Zenbot users
-
-[![zenbot logo](https://rawgit.com/deviavir/zenbot/master/assets/discord.png)](https://discord.gg/ZdAd2gP)
-
-Zenbot has a Discord chat! You can get in [through this invite link](https://discord.gg/ZdAd2gP).
-
 ## Donate
 
 P.S., some have asked for how to donate to Zenbot development. We accept donations at **Bitcoin addresses** below:
@@ -840,6 +822,11 @@ P.S., some have asked for how to donate to Zenbot development. We accept donatio
 
 Thanks!
 
+## Noteworthy forks
+
+- [bot18](https://medium.com/@carlos8f_11468/introducing-bot18-the-new-crypto-trading-bot-to-supersede-zenbot-and-unleash-the-zalgo-da8464b41e53)
+- [magic8bot](https://github.com/notVitaliy/magic8bot)
+
 - - -
 
 ### License: MIT

boot.js

@@ -11,6 +11,8 @@ module.exports = function (cb) {
   var config = {}
   var overrides = {}
 
+  module.exports.debug = args.debug
+
   // 1. load conf overrides file if present
   if(!_.isUndefined(args.conf)){
     try {

commands/balance.js

@@ -4,6 +4,7 @@ var minimist = require('minimist')
   , colors = require('colors')
   , moment = require('moment')
   , objectifySelector = require('../lib/objectify-selector')
+  , exchangeService = require('../lib/services/exchange-service')
   , { formatCurrency } = require('../lib/format')
 
 module.exports = function (program, conf) {
@@ -33,9 +34,18 @@ module.exports = function (program, conf) {
       so.debug = cmd.debug
       so.mode = 'live'
       function balance () {
-        s.exchange.getBalance(s, function (err, balance) {
+        var exchangeServiceInstance = exchangeService(conf)
+        var exchange = exchangeServiceInstance.getExchange()
+
+        var exchangeName = exchange.name // TODO: Refactor all exchanges to be in the format of the stub.exchange, so we can use getName() here.
+        if (exchange === undefined) {
+          console.error('\nSorry, couldn\'t find an exchange named [' + exchangeName + '].')
+          process.exit(1)
+        }
+
+        exchange.getBalance(s, function (err, balance) {
           if (err) throw err
-          s.exchange.getQuote(s, function (err, quote) {
+          exchange.getQuote(s, function (err, quote) {
             if (err) throw err
 
             var bal = moment().format('YYYY-MM-DD HH:mm:ss').grey + ' ' + formatCurrency(quote.ask, s.currency, true, true, false) + ' ' + (s.product_id).grey + '\n'
@@ -46,10 +56,10 @@ module.exports = function (program, conf) {
             console.log(bal)
 
             if (so.calculate_currency) {
-              s.exchange.getQuote({'product_id': s.asset + '-' + so.calculate_currency}, function (err, asset_quote) {
+              exchange.getQuote({'product_id': s.asset + '-' + so.calculate_currency}, function (err, asset_quote) {
                 if (err)  throw err
 
-                s.exchange.getQuote({'product_id': s.currency + '-' + so.calculate_currency}, function (err, currency_quote) {
+                exchange.getQuote({'product_id': s.currency + '-' + so.calculate_currency}, function (err, currency_quote) {
                   if (err)  throw err
                   var asset_total = balance.asset * asset_quote.bid
                   var currency_total = balance.currency * currency_quote.bid

commands/sim.js

@@ -158,6 +158,10 @@ module.exports = function (program, conf) {
           output_lines.push('error rate: ' + (sells ? n(losses).divide(sells).format('0.00%') : '0.00%').yellow)
         }
         options_output.simresults.start_capital = s.start_capital
+        options_output.simresults.last_buy_price = s.last_buy_price
+        options_output.simresults.last_assest_value = s.trades[s.trades.length-1].price
+        options_output.net_currency = s.net_currency
+        options_output.simresults.asset_capital = s.asset_capital
         options_output.simresults.currency = n(s.balance.currency).value()
         options_output.simresults.profit = profit.value()
         options_output.simresults.buy_hold = buy_hold.value()

commands/trade.js

@@ -14,6 +14,7 @@ var tb = require('timebucket')
   , objectifySelector = require('../lib/objectify-selector')
   , engineFactory = require('../lib/engine')
   , collectionService = require('../lib/services/collection-service')
+  , debug = require('../lib/debug')
 
 module.exports = function (program, conf) {
   program
@@ -519,8 +520,8 @@ module.exports = function (program, conf) {
                         console.log('\nDumping statistics...'.grey)
                         toggleStats()
                       } else if (key === 'L' && !info.ctrl) {
-                        so.debug = !so.debug
-                        console.log('\nDEBUG mode: ' + (so.debug ? 'ON'.green.inverse : 'OFF'.red.inverse))
+                        debug.flip()
+                        console.log('\nDEBUG mode: ' + (debug.on ? 'ON'.green.inverse : 'OFF'.red.inverse))
                       } else if (info.name === 'c' && info.ctrl) {
                         // @todo: cancel open orders before exit
                         console.log()

conf-sample.js

@@ -129,9 +129,9 @@ c.sell_pct = 99
 // ms to adjust non-filled order after
 c.order_adjust_time = 5000
 // avoid selling at a loss below this pct set to 0 to ensure selling at a higher price...
-c.max_sell_loss_pct = 25
+c.max_sell_loss_pct = 99
 // avoid buying at a loss above this pct set to 0 to ensure buying at a lower price...
-c.max_buy_loss_pct = 25
+c.max_buy_loss_pct = 99
 // ms to poll order status
 c.order_poll_time = 5000
 // ms to wait for settlement (after an order cancel)
@@ -252,4 +252,4 @@ c.output  = {}
 c.output.api = {}
 c.output.api.on = true
 c.output.api.ip = '0.0.0.0' // IPv4 or IPv6 address to listen on, uses all available interfaces if omitted
-c.output.api.port = 0 // 0 = random port
+c.output.api.port = 0 // 0 = random port, set to 17365 if you use docker

docker-compose-traefik.yml

@@ -0,0 +1,67 @@
+version: '3.1'
+services:
+  zenbotserver:
+    build:
+      context: .
+      dockerfile: Dockerfile
+    volumes:
+      - ./:/app/
+      - /app/node_modules/
+      - /app/dist/
+    restart: always
+    tty: true
+    expose:
+      - "17365"
+    labels:
+      - "traefik.enable=true"
+      - "traefik.frontend.rule=Host:$(TRAEFIK_HOST_ZEN)"
+      - "traefik.docker.network=$(TRAEFIK_NETWORK_NAME)"
+      - "traefik.port=17365"
+      - "traefik.frontend.auth.basic=$(BASIC_AUTH_ZEN)"
+    networks:
+      - internal
+      - proxy
+    depends_on:
+      - mongodb
+    environment:
+      - MONGODB_PORT_27017_TCP_ADDR=mongodb
+
+  mongodb:
+    image: mongo:latest
+    restart: always
+    volumes:
+      - ./data/db:/data/db
+    command: mongod --smallfiles --bind_ip=0.0.0.0 --logpath=/dev/null
+    networks:
+      - internal
+    expose:
+      - 27017
+
+  # "adminMongo is a Web based user interface (GUI) to handle all your MongoDB connections/databases needs."
+  adminmongo:
+    image: mrvautin/adminmongo
+    expose:
+      - 1234
+    depends_on:
+      - mongodb
+    environment:
+      - "CONN_NAME=zenbot_mongodb"
+      - "DB_HOST=mongodb"
+      - "DB_PORT=27017"
+    labels:
+      - "traefik.enable=true"
+      - "traefik.frontend.rule=Host:$(TRAEFIK_HOST_DB)"
+      - "traefik.docker.network=$(TRAEFIK_NETWORK_NAME)"
+      - "traefik.port=1234"
+      - "traefik.frontend.auth.basic=$(BASIC_AUTH_DB)"
+    networks:
+      - internal
+      - proxy
+    command: "npm start"
+
+networks:
+  proxy:
+    external:
+      name: "$(TRAEFIK_NETWORK_NAME)"
+  internal:
+    external: false