Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

WIP: Rework docs #1816

Merged
merged 41 commits into from
Mar 16, 2019
Merged

WIP: Rework docs #1816

merged 41 commits into from
Mar 16, 2019

Conversation

DJCrashdummy
Copy link
Contributor

  1. Hopefully I assumed right and you don't use the wiki (although it is active), but a docs-folder with md-files?

  2. This PR is by far NOT done yet! - I just wanted to get in touch (and eventually feedback), to see if my ideas/changes are welcome, before I put too much time and effort in it.

  3. I want to rework the docs, which means...

    • In first place shorten the main readme, because it almost overwhelms the reader at the first impression (and also as user of zenbot it isn't really a pleasure to handle it).
    • Create single and shorter files grouped by topic in the docs-folder (as it is already done for the exchanges).
    • Create a kind of an index-readme at the docs-folder.
    • And of course update some outdated parts.

and rearranged it a bit...
...to just have it parked somewhere for now.
@DeviaVir
Copy link
Owner

Hey @DJCrashdummy, thanks for looking at the docs, they are in much need of some TLC.

  1. You're right, I disabled the wiki.
  2. 👍
  3. 👍

@DJCrashdummy
Copy link
Contributor Author

DJCrashdummy commented Jan 17, 2019

Just to mention it:
I'll also change links within this project (whether to other docs, pictures or normal files) to relative links, as the chance is higher that they'll still work if something changes.

@DJCrashdummy
Copy link
Contributor Author

@DeviaVir
May I change the Node.js version in the install guides to 10.x (maintained until April 2021) in favour of 8.x (maintained until December 2019)? Or are there any downsides/restrictions/problems/etc. I'm not aware of?

@DeviaVir
Copy link
Owner

@DJCrashdummy we're not "officially" testing for 10.x right now, but I don't see a reason why not.
https://github.com/DeviaVir/zenbot/blob/unstable/.travis.yml#L4

@DJCrashdummy
Copy link
Contributor Author

Well... it is IMHO bad practice to recommend not tested things at guides (for beginners). So I rather stick with Node.js 8.x in the docs for now.


fyi: I'm running Zenbot (no live-trading for now) with Node.js 10.x and haven't noticed any major drawbacks, just some "DeprecationWarning" (3 at backfill, 2 at sim and 5 at trade --paper), but I've also hardly run Zenbot with Node.js 8.x.
Although there is one really annoying regression/bug (no idea if it is known - I haven't worked myself completely through the issues yet): as soon as I'm running a simulation for ~30 days or more, zenbot stalls at different positions and cancels after a few seconds with no message or output. As a workaround I wrote a bash-script myself to retry until completing simulation successfully, because it works sometimes without changing anything... it just took >100 attempts to end one of my simulations successfully.
--> is this known or should i open an issue for that?

btw: @DeviaVir or do you probably plan to jump directly to Node.js 12.x this spring?

@DeviaVir
Copy link
Owner

@DJCrashdummy

Well... it is IMHO bad practice to recommend not tested things at guides (for beginners). So I rather stick with Node.js 8.x in the docs for now.

fyi: I'm running Zenbot (no live-trading for now) with Node.js 10.x and haven't noticed any major drawbacks, just some "DeprecationWarning" (3 at backfill, 2 at sim and 5 at trade --paper), but I've also hardly run Zenbot with Node.js 8.x.
Although there is one really annoying regression/bug (no idea if it is known - I haven't worked myself completely through the issues yet): as soon as I'm running a simulation for ~30 days or more, zenbot stalls at different positions and cancels after a few seconds with no message or output. As a workaround I wrote a bash-script myself to retry until completing simulation successfully, because it works sometimes without changing anything... it just took >100 attempts to end one of my simulations successfully.
--> is this known or should i open an issue for that?

btw: @DeviaVir or do you probably plan to jump directly to Node.js 12.x this spring?

fair enough. There are currently no future plans, if it's a cheap win to switch to 12.x we probably will.

@BAKFR BAKFR mentioned this pull request Jan 23, 2019
@BAKFR
Copy link
Contributor

BAKFR commented Jan 25, 2019

@DJCrashdummy feel free to recommend Node v10
It works with the last version, and I've updated the Travis config.

@DJCrashdummy
Copy link
Contributor Author

@BAKFR thank you for the info!
so if i read your MR correct, it seems to me that the "official" recommended LTS-version is now Node.js 10.x... than i'll change it.

@DJCrashdummy
Copy link
Contributor Author

[...] there is one really annoying regression/bug [...]: as soon as I'm running a simulation for ~30 days or more, zenbot stalls at different positions and cancels after a few seconds with no message or output. As a workaround I wrote a bash-script myself to retry until completing simulation successfully, because it works sometimes without changing anything... it just took >100 attempts to end one of my simulations successfully.
--> is this known or should i open an issue for that?

any comments on that?!?
is this or something like that already known, or completely new? - because i'm officially clueless regarding that issue. ☹️

@DJCrashdummy
Copy link
Contributor Author

DJCrashdummy commented Feb 4, 2019

one tiny question about explaining the example-trade:
there are some options mentioned like --sell_rate=-0.006 and --max_sell_duration=4 for example... i managed to map nearly all used (and outdated resp. renamed) options also from the linked raw data to current options, except the --sell_rate and --max_sell_duration. 😕

can someone please explain these two options to me or point me to the currently used equivalents!?


EDIT: --sell_rate=<value> and --max_sell_duration=<value> seem to be deprecated (or perhaps hardcoded without the possibility to override them) because varying their value doesn't have any impact on the results of a quick simulation.
anyhow... i would appreciate a confirmation or correction, because i'm uncomfortable explaining something i doesn't have fully understood myself.

@DeviaVir DeviaVir merged commit c96fbce into DeviaVir:unstable Mar 16, 2019
@DeviaVir
Copy link
Owner

I've gone ahead and merged this in, further work on docs can be done by others building on top of your great work, thank you @DJCrashdummy!

YarnSeemannsgarn pushed a commit to YarnSeemannsgarn/zenbot that referenced this pull request Apr 15, 2020
* shortened the readme

and rearranged it a bit...

* added cut out parts of the old readme

...to just have it parked somewhere for now.

* corrected links

* Create requirements.md

* Create debian-ubuntu.md

* Create docker.md

* Create install.md

* Create notifiers.md

* Create list-strategies.md

* Create trend_ema.md

* Create macd.md

* Create rsi.md

* Create sar.md

* Create speed.md

* Create tweaking.md

* moved raspberrypi.md into install-folder

...and corrected minor errors.

* Create noop.md

* added Pushover

...and minor cleanup.

* made an own section for Documentation

...and other minor polish.

* Delete discord.png

* updated FAQs

and also rearranged, ordered and polished them a bit.

* fixed jump-marks

* audited headers

* fixed last header

* improved ("automatized") jump-marks

* deleted old ("manual") jump-marks

* reworked links

* fixed jump-marks again

* added Binance, HitBTC & TheRockTrading to the supported exchanges

...and reordered all of them alphabetically.

* sorted OSes according recommendation

* made it match the other guides

* added link to install guide

* reworked guide a bit

* separated links

* minor corrections

* minor polish

* moved & renamed file

and added a zenbot command at the end

* moved file

* moved file

* moved file

* moved file
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants