Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Mongo: add replicaSet support #222

Merged
merged 3 commits into from
Jun 6, 2017
Merged

Mongo: add replicaSet support #222

merged 3 commits into from
Jun 6, 2017

Conversation

DeviaVir
Copy link
Owner

@DeviaVir DeviaVir commented Jun 5, 2017

fixes #179

conf-sample.js Outdated
@@ -7,6 +7,7 @@ c.mongo.port = 27017
c.mongo.db = 'zenbot4'
c.mongo.username = null
c.mongo.password = null
c.mongo.replicaSet = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a explanatory comment here, as this setting is not self explanatory.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair, I added a comment hopefully explaining it and the implementation of it enough.

@Fjuxx
Copy link
Contributor

Fjuxx commented Jun 6, 2017

why use c.mongo.replicaSet = '' while you are using null for the other fields?
like: c.mongo.password = null

@DeviaVir DeviaVir merged commit b6cc96a into DeviaVir:master Jun 6, 2017
@DeviaVir DeviaVir deleted the deviavir/mongo/replicaset branch June 6, 2017 10:54
supersabbath pushed a commit to supersabbath/zenbot that referenced this pull request Oct 2, 2017
* Mongo: add replicaSet support

* Aesthetics for replicaSet

* Update conf-sample.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants