Different Bittrex error (#659) #715
Conversation
This fix should handle any error that happens and then fire's off a retry. I tried the Try .. Catch block on fiddle and it worked flawlessly to capture the error in question. I'm not sure how to exactly test the retry, but I created the statement similar to the one on line 78. This technically should be recoverable, because Bittrex is just having some sort of hiccup on their API sending data.
|
Unfortunately the issue is still there.
|
|
@ljankok , could it be that you have the version that I first committed? I found that using the typeof in the if did not work properly. I had to convert it to a Try...Catch statement to get this one and work around it. I was just running it today and it happened. It seems to have worked for me. If you are comfortable reviewing the code. Take a look at exchange.js in the bittrex folder. On line 85 you should see a try statement instead of an if statement. If you see an if, then you have the first attempt at trying to get this to work properly. Please let us know if it is a try instead of an if. It is hard to duplicate this due to the nature of the occurance. So it has to be dealt with in the wild and I will try to come up with Plan C at this point. |
|
After I have started zenbot again I can also confirm that the fix is working. I reviewed the code and your catch statement indeed looks like the type of exception which is needed.
|
Cleaned up the error message so that the console.log is gone and rely on the retry error message instead.
* Correction for Incorrect Volume in Bittrex * Cleanup error message (#715) Cleaned up the error message so that the console.log is gone and rely on the retry error message instead.
This fix should handle any error that happens and then fire's off a retry. I tried the Try .. Catch block on fiddle and it worked flawlessly to capture the error in question.
I'm not sure how to exactly test the retry, but I created the statement similar to the one on line 78. This technically should be recoverable, because Bittrex is just having some sort of hiccup on their API sending data.
I would say this would close #659, but time will ultimately tell.