Skip to content

Support semantic variable generation #39

Support semantic variable generation

Support semantic variable generation #39

Triggered via pull request November 17, 2024 12:12
@Devin-YeungDevin-Yeung
synchronize #7
id
Status Success
Total duration 49s
Artifacts

ci.yml

on: pull_request
stable / fmt
10s
stable / fmt
nightly / doc
28s
nightly / doc
ubuntu / stable / coverage
4s
ubuntu / stable / coverage
Spell Check
3s
Spell Check
Matrix: clippy
Matrix: os-check
Matrix: required
Fit to window
Zoom out
Zoom in

Annotations

9 warnings
useless conversion to the same type: `std::string::String`: /home/runner/work/bnfgen/bnfgen/target/debug/build/bnfgen-425e20e80eb4f7df/out/parser.rs#L2293
warning: useless conversion to the same type: `std::string::String` --> /home/runner/work/bnfgen/bnfgen/target/debug/build/bnfgen-425e20e80eb4f7df/out/parser.rs:2293:35 | 2293 | name: Rc::new(nt.into()), | ^^^^^^^^^ help: consider removing `.into()`: `nt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
match expression looks like `matches!` macro: src/grammar/symbol.rs#L144
warning: match expression looks like `matches!` macro --> src/grammar/symbol.rs:144:9 | 144 | / match self { 145 | | SymbolKind::Terminal(_) | SymbolKind::Regex(_) => true, 146 | | _ => false, 147 | | } | |_________^ help: try: `matches!(self, SymbolKind::Terminal(_) | SymbolKind::Regex(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
writing `&Vec` instead of `&[_]` involves a new object where a slice will do: src/grammar/graph.rs#L66
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> src/grammar/graph.rs:66:33 | 66 | fn is_trap_loop(&self, scc: &Vec<NodeIndex>) -> bool { | ^^^^^^^^^^^^^^^ help: change this to: `&[NodeIndex]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default
match expression looks like `matches!` macro: src/grammar/alt.rs#L52
warning: match expression looks like `matches!` macro --> src/grammar/alt.rs:52:9 | 52 | / match self.invoke_limit { 53 | | Limit::Unlimited => false, 54 | | _ => true, 55 | | } | |_________^ help: try: `!matches!(self.invoke_limit, Limit::Unlimited)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro = note: `#[warn(clippy::match_like_matches_macro)]` on by default
associated function `new` is never used: src/regex.rs#L20
warning: associated function `new` is never used --> src/regex.rs:20:8 | 19 | impl Regex { | ---------- associated function in this implementation 20 | fn new(input: &str) -> Self { | ^^^
method `children_len` is never used: src/parse_tree/tree.rs#L21
warning: method `children_len` is never used --> src/parse_tree/tree.rs:21:19 | 12 | impl<T> ParseTree<T> { | -------------------- method in this implementation ... 21 | pub(crate) fn children_len(&self) -> usize { | ^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
type `grammar::symbol::SymbolKind` is more private than the item `grammar::checked::ReduceOutput::NonTerminal::syms`: src/grammar/checked.rs#L19
warning: type `grammar::symbol::SymbolKind` is more private than the item `grammar::checked::ReduceOutput::NonTerminal::syms` --> src/grammar/checked.rs:19:9 | 19 | syms: Vec<SymbolKind>, | ^^^^^^^^^^^^^^^^^^^^^ field `grammar::checked::ReduceOutput::NonTerminal::syms` is reachable at visibility `pub` | note: but type `grammar::symbol::SymbolKind` is only usable at visibility `pub(crate)` --> src/grammar/symbol.rs:101:1 | 101 | pub(crate) enum SymbolKind { | ^^^^^^^^^^^^^^^^^^^^^^^^^^
type `grammar::symbol::SymbolKind` is more private than the item `generator::TreeGenerator::generate`: src/generator.rs#L44
warning: type `grammar::symbol::SymbolKind` is more private than the item `generator::TreeGenerator::generate` --> src/generator.rs:44:5 | 44 | / pub fn generate<R: Rng, S: Into<String>>( 45 | | &self, 46 | | start: S, 47 | | rng: &mut R, 48 | | ) -> ParseTree<SymbolKind> { | |______________________________^ method `generator::TreeGenerator::generate` is reachable at visibility `pub` | note: but type `grammar::symbol::SymbolKind` is only usable at visibility `pub(crate)` --> src/grammar/symbol.rs:101:1 | 101 | pub(crate) enum SymbolKind { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: `#[warn(private_interfaces)]` on by default
unused variable: `comma`: /home/runner/work/bnfgen/bnfgen/target/debug/build/bnfgen-425e20e80eb4f7df/out/parser.rs#L2204
warning: unused variable: `comma` --> /home/runner/work/bnfgen/bnfgen/target/debug/build/bnfgen-425e20e80eb4f7df/out/parser.rs:2204:9 | 2204 | (_, comma, _): (usize, Option<Token>, usize), | ^^^^^ help: if this is intentional, prefix it with an underscore: `_comma` | = note: `#[warn(unused_variables)]` on by default