Support typed BNF grammar #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devin-Yeung
force-pushed
the
constraint
branch
from
9b075cb to
c2ae074
Compare
There was a problem hiding this comment.
Copilot reviewed 6 out of 16 changed files in this pull request and generated 3 suggestions.
Files not reviewed (10)
- src/grammar/snapshots/bnfgen__grammar__test__brainfuck.snap: Language not supported
- src/grammar/snapshots/bnfgen__grammar__test__invalid_token.snap: Language not supported
- src/grammar/snapshots/bnfgen__grammar__test__repeat.snap: Language not supported
- src/grammar/snapshots/bnfgen__grammar__test__typed.snap: Language not supported
- src/grammar/snapshots/bnfgen__grammar__test__unexpected_eof.snap: Language not supported
- src/parser.lalrpop: Language not supported
- src/utils.rs: Evaluated as low risk
- src/generator.rs: Evaluated as low risk
- src/grammar/checked.rs: Evaluated as low risk
- src/grammar/mod.rs: Evaluated as low risk
Devin-Yeung
force-pushed
the
constraint
branch
from
f61a4c7 to
8ca11f4
Compare
There was a problem hiding this comment.
Copilot reviewed 6 out of 20 changed files in this pull request and generated 2 suggestions.
Files not reviewed (14)
- examples/set-algebra-typed.bnfgen: Language not supported
- src/grammar/snapshots/bnfgen__grammar__test__brainfuck.snap: Language not supported
- src/grammar/snapshots/bnfgen__grammar__test__invalid_token.snap: Language not supported
- src/grammar/snapshots/bnfgen__grammar__test__repeat.snap: Language not supported
- src/grammar/snapshots/bnfgen__grammar__test__typed.snap: Language not supported
- src/grammar/snapshots/bnfgen__grammar__test__unexpected_eof.snap: Language not supported
- src/parser.lalrpop: Language not supported
- src/snapshots/bnfgen__generator__test__tree_generator.snap: Language not supported
- src/snapshots/bnfgen__generator__test__typed_generator.snap: Language not supported
- src/snapshots/bnfgen__generator__test__typed_set_algebra.snap: Language not supported
- src/utils.rs: Evaluated as low risk
- src/grammar/rule.rs: Evaluated as low risk
- src/token.rs: Evaluated as low risk
- src/grammar/mod.rs: Evaluated as low risk
Devin-Yeung
force-pushed
the
constraint
branch
from
5e116ad to
20431eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces typing for the BNF grammar extension, specifically, each
non-terminalcan be typed (optionally). For example, a common use case is arithmetic expressions: