Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/build tsup #104

Merged
merged 11 commits into from
Sep 5, 2022
Merged

Feature/build tsup #104

merged 11 commits into from
Sep 5, 2022

Conversation

eric-burel
Copy link
Contributor

@eric-burel eric-burel commented Sep 1, 2022

  • Setup Tsup for API internal + fix a few ESM compatibility issue
  • Figure out __dirname: https://blog.logrocket.com/alternatives-dirname-node-js-es-modules/ => I've pushed a dirty fix but the folder might be wrong, instead we should use URL as shown in the article
  • Same for API
  • Create a "script" folder also using Tsup for building TS scripts

Tsup is based on Esbuild and Rollup, it's usually working as expected and enjoy third party plugins from Esbuild.

/!\ Esbuild use modern standards (ESM) as a default, so we have to be careful eg when importing "lodash" (use "lodash/foo.js" instead of "lodash/foo"), using require (use import), or importing commonJs default exports (see "responseCachePlugin" for example).

@vercel
Copy link

vercel bot commented Sep 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
surveyform ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 9:43AM (UTC)

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for stateofjs2021 failed.

Name Link
🔨 Latest commit c6d3098
🔍 Latest deploy log https://app.netlify.com/sites/stateofjs2021/deploys/6311cf31823d520008542b01

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for devographics-static canceled.

Name Link
🔨 Latest commit c6d3098
🔍 Latest deploy log https://app.netlify.com/sites/devographics-static/deploys/6311cf31d5d72e0008381e3b

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for stateofgraphql2022 failed.

Name Link
🔨 Latest commit c6d3098
🔍 Latest deploy log https://app.netlify.com/sites/stateofgraphql2022/deploys/6311cf32823d520008542b06

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for stateofjs failed.

Name Link
🔨 Latest commit c6d3098
🔍 Latest deploy log https://app.netlify.com/sites/stateofjs/deploys/6311cf32d5d72e0008381e40

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for stateofcss failed.

Name Link
🔨 Latest commit c6d3098
🔍 Latest deploy log https://app.netlify.com/sites/stateofcss/deploys/6311cf326e973800085c80d9

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for devographics-graphiql-internal canceled.

Name Link
🔨 Latest commit c6d3098
🔍 Latest deploy log https://app.netlify.com/sites/devographics-graphiql-internal/deploys/6311cf3283b6160009fcfd14

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for stateofcss2021 failed.

Name Link
🔨 Latest commit c6d3098
🔍 Latest deploy log https://app.netlify.com/sites/stateofcss2021/deploys/6311cf3183b6160009fcfd0e

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for state-of-graphql failed.

Name Link
🔨 Latest commit c6d3098
🔍 Latest deploy log https://app.netlify.com/sites/state-of-graphql/deploys/6311cf3186c7640008fc3e12

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for graphiql-devographics canceled.

Name Link
🔨 Latest commit c6d3098
🔍 Latest deploy log https://app.netlify.com/sites/graphiql-devographics/deploys/6311cf3286c7640008fc3e17

@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 1, 2022

Gatsby Cloud Build Report

🚩 Your build failed. See the build logs here

Errors

Invalid plugin options for "gatsby-source-graphql":

- "value" must contain at least one of [url, createLink]
Invalid plugin options for "gatsby-source-graphql":

- "value" must contain at least one of [url, createLink]

@SachaG SachaG marked this pull request as ready for review September 5, 2022 00:51
@SachaG SachaG merged commit a612aca into main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants