Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send all the join requests in a single batch #112

Closed
CBenoit opened this issue May 1, 2023 · 0 comments · Fixed by #347
Closed

Send all the join requests in a single batch #112

CBenoit opened this issue May 1, 2023 · 0 comments · Fixed by #347
Labels
A-core Area: Core tier enhancement New feature or request good first issue Good for newcomers P-low Low priority

Comments

@CBenoit
Copy link
Member

CBenoit commented May 1, 2023 •
edited
Loading

RDP 4.0, 5.0, 5.1, 5.2, 6.0, 6.1, 7.0, 7.1, 8.0, 10.2, 10.3, 10.4, and 10.5 clients send a Channel Join Request to the server only after the Channel Join Confirm for a previously sent request has been received. RDP 8.1, 10.0, and 10.1 clients send all of the Channel Join Requests to the server in a single batch to minimize the overall connection sequence time.

Let’s send all the Join Requests in a single batch in IronRDP.

TODO comment in code
@CBenoit CBenoit added enhancement New feature or request good first issue Good for newcomers labels May 1, 2023
@CBenoit CBenoit added A-extra Area: Extra tier A-core Area: Core tier and removed A-extra Area: Extra tier labels Aug 22, 2023
@CBenoit CBenoit added the P-low Low priority label Nov 1, 2023
@CBenoit CBenoit mentioned this issue Dec 8, 2023
Merged
CBenoit added a commit that referenced this issue Jan 9, 2024
@CBenoit
fix(connector): send join requests in a single batch
c81f5f8 
Issue: #112
CBenoit added a commit that referenced this issue Jan 9, 2024
@CBenoit
fix(connector): send join requests in a single batch
f53b7cb 
Issue: #112
This was referenced Jan 9, 2024
Merged
Open
CBenoit added a commit that referenced this issue Jan 9, 2024
@CBenoit
fix(connector): send join requests in a single batch (#347)
db9a7cc 
Issue: #112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-core Area: Core tier enhancement New feature or request good first issue Good for newcomers P-low Low priority
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(connector): send join requests in a single batch Devolutions/IronRDP
1 participant
@CBenoit