-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clipboard PDU support #170
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good.
Do you think you could move the clipboard PDUs into its own crate? I’m thinking about a crate named after the name of the channel: ironrdp-cliprdr
.
This crate will also provides the implementation of the static channel itself in the future.
What do you think?
Sounds good to me, will do that 👍 |
@CBenoit I made the refactoring, PR is ready for review again 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, minor comments
@CBenoit I fixed last batch of comments 😄 |
Coverage Report 🤖 ⚙️Past: New: Diff: -0.82% [this comment will be updated automatically] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Add support for clipboard virtual channel PDUs encode/decode logic [MS-RDPECLIP].
Although only textual representation is needed in the first iteration(#107), this PR implements all PDUs defined in [MS-RDPECLIP] specification.
The feature was tested against PDU blobs presented in section 4 (examples) of [MS-RDPECLIP]