Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ffi): add a client example using Avalonia #443

Merged
merged 22 commits into from
Apr 24, 2024

Conversation

irvingoujAtDevolution
Copy link
Contributor

@irvingoujAtDevolution irvingoujAtDevolution commented Apr 22, 2024

  1. Add example RDP client using Avalonia
  2. Generate extra bindings necessary

Demo:

Avalonia.Demo.mp4

Note: As this is an example for demonstration purpose, many things are not implemented.
Currently only simple keyboard and cursor move/click events are implemented.

Copy link

github-actions bot commented Apr 22, 2024

Coverage Report 🤖 ⚙️

Past:
Total lines: 29646
Covered lines: 17249 (58.18%)

New:
Total lines: 29646
Covered lines: 17244 (58.17%)

Diff: -0.02%

[this comment will be updated automatically]

@@ -27,7 +27,7 @@ pub mod ffi {
}

impl ClientConnectorState {
pub fn get_type(&self) -> Result<ClientConnectorStateType, Box<IronRdpError>> {
pub fn get_enum_type(&self) -> Result<ClientConnectorStateType, Box<IronRdpError>> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid naming conflict with C# GetType()

@irvingoujAtDevolution irvingoujAtDevolution changed the title ffi binding client example feat(ffi): Add C# bindings and client example using Avalonia Apr 22, 2024
@irvingoujAtDevolution irvingoujAtDevolution changed the title feat(ffi): Add C# bindings and client example using Avalonia feat(ffi): Add more C# bindings and a client example using Avalonia Apr 22, 2024
@irvingoujAtDevolution irvingoujAtDevolution marked this pull request as ready for review April 22, 2024 16:16
ffi/dotnet/Devolutions.IronRdp/Generated/Char.cs Outdated Show resolved Hide resolved
ffi/dotnet/Devolutions.IronRdp/src/Framed.cs Outdated Show resolved Hide resolved
ffi/src/connector/config.rs Outdated Show resolved Hide resolved
ffi/src/input.rs Outdated Show resolved Hide resolved
ffi/src/input.rs Outdated Show resolved Hide resolved
@CBenoit
Copy link
Member

CBenoit commented Apr 23, 2024

Nice job! Do you have a demonstration video?

@CBenoit CBenoit changed the title feat(ffi): Add more C# bindings and a client example using Avalonia feat(ffi): add a client example using Avalonia Apr 23, 2024
@CBenoit CBenoit enabled auto-merge (squash) April 23, 2024 11:56
@irvingoujAtDevolution
Copy link
Contributor Author

Nice job! Do you have a demonstration video?

Do you mean a demo video for running the example?
https://github.com/Devolutions/IronRDP/assets/139169536/548cbad0-6d6f-4907-8784-b6b59300eb53

Co-authored-by: Benoît Cortier <bcortier@proton.me>
Co-authored-by: Benoît Cortier <bcortier@proton.me>
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@CBenoit CBenoit merged commit a232b4e into master Apr 24, 2024
7 checks passed
@CBenoit CBenoit deleted the ffi-binding-client-example branch April 24, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants