Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): let address resolve to either ipv4 or ipv6 #524

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix(client): let address resolve to either ipv4 or ipv6 #524

merged 1 commit into from
Aug 9, 2024

Conversation

elmarco
Copy link
Contributor

@elmarco elmarco commented Aug 7, 2024

Let TcpStream::connect() handle address resolution, so that multiple addresses (typically localhost -> ipv4 127.0.0.1 or ipv6 ::1) are attempted.

@elmarco
feat(client): let address resolve to either ipv4 or ipv6
4aa935a 
Let TcpStream::connect() handle address resolution, so that multiple
addresses (typically localhost -> ipv4 127.0.0.1 or ipv6 ::1) are
attempted.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
CBenoit
CBenoit approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Marking the patch as fix since old behavior was probably not really intended.

@CBenoit CBenoit changed the title feat(client): let address resolve to either ipv4 or ipv6 fix(client): let address resolve to either ipv4 or ipv6 Aug 9, 2024
@CBenoit CBenoit merged commit d5f069c into Devolutions:master Aug 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBenoit CBenoit CBenoit approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elmarco @CBenoit