Draft: feat(server): credentials (with credssp) #558
+408
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBenoit
changed the title
elmarco
changed the title
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Modify Acceptor to take optionally Credentials at construct time. The credentials can be changed via ServerEvent::SetCredentials. Unauthorized connections are no longer accepted. However, I don't know how to report the error to the client correctly. For now it returns a SetErrorInfo/DeniedConnection, but that doesn't seem appropriate during the connection sequence. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify Acceptor to take optionally Credentials at construct time.
The credentials can be changed via ServerEvent::SetCredentials.
Unauthorized connections are no longer accepted.
However, I don't know how to report the error to the client correctly. For now it returns a SetErrorInfo/DeniedConnection, but that doesn't seem appropriate during the connection sequence.