Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues after async-upgrade branch review #126

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Fixed issues after async-upgrade branch review #126

merged 3 commits into from
Dec 10, 2020

Conversation

pacmancoder
Copy link
Contributor

@pacmancoder pacmancoder commented Dec 10, 2020 •
edited
Loading

Addressed issues from #124

@pacmancoder
Copy link
Contributor Author

@bcortier-devolutions A have addressed all issues from the previous PR;

Also in order to completely solve the comment #124 (comment) I am completely eliminated raw Futures (poll implementation) from jet_client.rs and replaced them with the async functions, but I still need to do some testing to validate that everything works, and after that I will make this PR non-draft

bcortier-devolutions
bcortier-devolutions approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@bcortier-devolutions bcortier-devolutions left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all good to me! Thank you! I'll just wait for your call 😄
Edit: you would also need to run cargo fmt for CI

@pacmancoder pacmancoder changed the title [WIP] Fixed issues after async-upgrade branch review Fixed issues after async-upgrade branch review Dec 10, 2020
@pacmancoder pacmancoder marked this pull request as ready for review December 10, 2020 14:56
@pacmancoder
Copy link
Contributor Author

@bcortier-devolutions Branch is ready for the merge

@bcortier-devolutions
Copy link
Contributor

Perfect! Good job!

@bcortier-devolutions bcortier-devolutions merged commit 8ccc2b5 into master Dec 10, 2020
@bcortier-devolutions bcortier-devolutions deleted the async-upgrade-fixes branch December 10, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcortier-devolutions bcortier-devolutions bcortier-devolutions approved these changes

@awakecoding awakecoding Awaiting requested review from awakecoding

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pacmancoder @bcortier-devolutions