-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix session recording #153
Conversation
@@ -46,15 +92,27 @@ impl PacketInterceptor for PcapRecordingInterceptor { | |||
debug!("New packet intercepted. Packet size = {}", data.len()); | |||
|
|||
let server_info = self.server_info.lock().unwrap(); | |||
let is_from_server = source_addr.unwrap() == server_info.addr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source_addr: Could it be none and panic ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now, the answer is not. But I added the check up in case if something will change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added creating of additional frames by timeout.
Added path api for the feature sogar integration.
Updated api according to the changes in the libarary.