Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): recursively reset permissions on the ProgramData directory #353

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

thenextman
Copy link
Member

The installer invokes calcs.exe to reset the permissions on %programdata%\Devolutions\Gateway

However, if a user or tool has previously edited permissions on a file within the directory (and removed the "inheritance" flag), those permissions will not be reset. By adding the /t switch to calcs, we can ask it to traverse subdirectories and files:

/t | Changes ACLs of specified files in the current directory and all subdirectories.

@thenextman thenextman requested a review from a team October 27, 2022 16:20
@CBenoit
Copy link
Member

CBenoit commented Oct 27, 2022

cc @MathieuMorrissette
Tagging VM-1061

Copy link
Contributor

@MathieuMorrissette MathieuMorrissette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBenoit CBenoit merged commit e04ada9 into master Oct 27, 2022
@CBenoit CBenoit deleted the installer-improvement branch October 27, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants