Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): avoid unicode char literals #376

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

thenextman
Copy link
Member

@thenextman thenextman commented Jan 16, 2023

Unicode character literals in source files can be problematic, depending on the editor and encoding. Instead, avoid the issue by masking the character with an asterisk instead of a unicode "bullet".

Issue: DGW-74

@thenextman thenextman enabled auto-merge (squash) January 16, 2023 15:16
@thenextman thenextman changed the title fix{installer}: avoid unicode char literals fix(installer): avoid unicode char literals Jan 16, 2023
@thenextman thenextman enabled auto-merge (squash) January 16, 2023 15:40
@thenextman thenextman enabled auto-merge (rebase) January 16, 2023 15:40
@thenextman thenextman enabled auto-merge (squash) January 16, 2023 15:41
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dion-gionet dion-gionet merged commit 8d94f94 into master Jan 16, 2023
@dion-gionet dion-gionet deleted the installer-unicode-literal branch January 16, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants