Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pwsh): sort certification chain from leaf to root #394

Merged
merged 2 commits into from
Mar 6, 2023
Merged

fix(pwsh): sort certification chain from leaf to root #394

merged 2 commits into from
Mar 6, 2023

Conversation

CBenoit
Copy link
Member

@CBenoit CBenoit commented Mar 4, 2023

Issue: DGW-80

@CBenoit CBenoit enabled auto-merge (squash) March 4, 2023 03:34
awakecoding
awakecoding approved these changes Mar 4, 2023
View reviewed changes
Copy link
Contributor

@awakecoding awakecoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Déjà? Tes skills en PowerShell s'améliorent! As-tu testé avec différentes chaînes?

@CBenoit
Copy link
Member Author

CBenoit commented Mar 4, 2023 •
edited
Loading

Déjà? Tes skills en PowerShell s'améliorent! As-tu testé avec différentes chaînes?

J’ai testé avec la chaîne de Devolutions Lab, mais ça pourrait sûrement prendre plus de tests pour être bien sûr
Je regarde ça lundi :)

@CBenoit CBenoit requested review from a team as code owners March 6, 2023 17:14
@CBenoit
Copy link
Member Author

CBenoit commented Mar 6, 2023 •
edited
Loading

J’ai ajouté des tests Pester pour bien valider que ça fonctionne (et éviter de briser ce bout dans le futur). J’ai aussi fait en sorte que ces tests soient roulés dans le CI et rebasé la branche sur master.

@CBenoit CBenoit merged commit f7ff93c into master Mar 6, 2023
@CBenoit CBenoit deleted the DGW-80 branch March 6, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awakecoding awakecoding awakecoding approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CBenoit @awakecoding