Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial session recording listing (/jet/jrec/list) #412

Merged
merged 1 commit into from
Apr 26, 2023
Merged

initial session recording listing (/jet/jrec/list) #412

merged 1 commit into from
Apr 26, 2023

Conversation

awakecoding
Copy link
Contributor

Here's my first shot at implementing session recording listing using a scope token. It's just half the work, here's what I don't like about it:

  • not enough error handling (probably panics if directory is empty)
  • scope token cannot be reused, not sure how to make it reusable
  • result is a vector of strings, maybe we'd like a vector of objects
  • result is not sorted, file creation time sorting would be best

CBenoit
CBenoit approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBenoit CBenoit merged commit 332c86f into master Apr 26, 2023
@CBenoit CBenoit deleted the jrec-list branch April 26, 2023 13:15
@CBenoit CBenoit mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBenoit CBenoit CBenoit approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awakecoding @CBenoit