Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): limit builds on forked PRs, optimize CI workflow #441

Merged
merged 1 commit into from
May 18, 2023

Conversation

thenextman
Copy link
Member

  • Although it's possible to check if we're on a fork (and even to check for dependabot builds by checking github.actor), it's not possible to exclude a job based on a matrix condition. Instead, generate the build matrices dynamically using PowerShell. This allows us to drop the Windows builds in case secrets are not available (e.g. a PR from a fork). A warning will be printed in this case.
  • Revert to using secrets.ARTIFACTORY_READ_TOKEN. This token is now available for builds from dependabot.
  • Don't bootstrap conan or OpenSSL when building for non-Windows.
  • Drop the jetsocat build for the Windows x86 target.

@thenextman thenextman requested a review from CBenoit May 18, 2023 17:30
@thenextman thenextman requested review from a team as code owners May 18, 2023 17:30
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice dynamic matrix trick

Nit: instead of fix(ci):, there is a commit type ci

ci: limit builds on forked PRs, optimize CI workflow

I use this to put related commits in a "Continuous Integration" section in our changelog:
image

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@CBenoit CBenoit enabled auto-merge (squash) May 18, 2023 18:06
@CBenoit CBenoit merged commit 39d5f9a into master May 18, 2023
@CBenoit CBenoit deleted the fix-forked-ci branch May 18, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants