Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(dgw): use a buffer of 1k bytes for ARD VNC sessions #809

Merged
merged 7 commits into from
Apr 15, 2024
Merged

perf(dgw): use a buffer of 1k bytes for ARD VNC sessions #809

merged 7 commits into from
Apr 15, 2024

Commits on Apr 15, 2024

  1. fix: Use 1024 buffer size for ARD VNC session 

    _ARD_ uses _MVS_ video codec which doesn't like buffering, and we need to have the buffer as minimal as possible.

Also, this commit adds new `copy_bidirectional` transport that is forked [the one from tokio](https://docs.rs/tokio/latest/tokio/io/fn.copy_bidirectional.html).
It's forked because the original function doesn't allow overriding the buffer size (8K is used by default). There is [an issue](tokio-rs/tokio#6454) on tokio side for it. We will be able to replace our fork with the upstream easily when it's ready.

Releated to Devolutions/IronVNC#338.
    @RRRadicalEdward
    RRRadicalEdward committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    206fecd View commit details
    Browse the repository at this point in the history

  2. fix(ci): run cargo fmt

    @RRRadicalEdward
    RRRadicalEdward committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    3c59de0 View commit details
    Browse the repository at this point in the history

  3. Update crates/transport/src/copy_bidirectional.rs 

    Co-authored-by: Benoît Cortier <bcortier@proton.me>
    @RRRadicalEdward @CBenoit
    RRRadicalEdward and CBenoit authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    9a3c01f View commit details
    Browse the repository at this point in the history

  4. review: fix reexport

    @RRRadicalEdward
    RRRadicalEdward committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    4fea288 View commit details
    Browse the repository at this point in the history

  5. review: move copy_buffer.rs code to copy_bidirectional.rs

    @RRRadicalEdward
    RRRadicalEdward committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d8dd5e3 View commit details
    Browse the repository at this point in the history

  6. fix(ci): run cargo fmt

    @RRRadicalEdward
    RRRadicalEdward committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d604e95 View commit details
    Browse the repository at this point in the history

  7. Update crates/transport/src/copy_bidirectional.rs

    @CBenoit
    CBenoit authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f31d8b3 View commit details
    Browse the repository at this point in the history