fix(dgw): error code on service startup failure #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of panicking when failing to start the service, we instead attempt to log the error to the log file and return an error code. Issue: DGW-174
CBenoit
commented
Apr 18, 2024
Comment on lines
+128
to
+129
| const BAD_CONFIG_ERR_CODE: u32 = 1; | ||
| const START_FAILED_ERR_CODE: u32 = 2; |
There was a problem hiding this comment.
These are the two status code we now return when failing on startup. When the config is invalid, the logger is never initialized, so we can’t log the exact error, but we know roughly were to look. It’s also possible to run the executable manually in the terminal to get the detailed error. For the other error, the logger will typically be ready (except if the error is us being unable to setup the logger).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of panicking when failing to start the service, we instead attempt to log the error to the log file and return an error code.
Issue: DGW-174