fix(installer)!: install Gateway service as NetworkService #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenextman
force-pushed
the
install-network-service
branch
from
1263d3c
to
4862902
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install the Devolutions Gateway service under the
NetworkServiceaccount instead ofLocalSystem. This significantly reduces the permissions available to the service account.Relevant file paths are updated to grant
NetworkServicethe appropriate access. Broadly, file permissions in %programdata%/Devolutions/Gateway are inherited from the "Gateway" parent directory. In my tests there is no issue; however it could cause a problem if users have manually adjusted file permissions or customized their setup in unforeseen ways.Warning
We attempted this modification before but backed out again after at least one breaking problem in a customer environment. This is a change that we must make and we are likely in a better footing now to diagnose and deal with any resultant problems. If possible, we should call this out in the release notes as a potentially breaking change.
Additionally, rollback the
wixtoolsetversion in CI. Latest GitHub runners ship version 3.14.1, which is broken. This can be reverted once 3.14.2 is published to chocolatey and the runner images are updated.Issue: VM-1923