Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dgw): support .cast terminal recording files #900

Merged
merged 3 commits into from
Jun 26, 2024
Merged

feat(dgw): support .cast terminal recording files #900

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d179b5
fit(gateway): support .cast file recording for terminal sessions
irvingoujAtDevolution Jun 25, 2024
1538f1c
Apply suggestions from code review
CBenoit Jun 26, 2024
146179e
Update devolutions-gateway/src/token.rs
CBenoit Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions devolutions-gateway/src/token.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,13 +262,16 @@ pub enum RecordingFileType {
WebM,
/// Terminal Playback
TRP,
/// asciinema cast for terminal playback
Asciicast,
Copy link
Member

@CBenoit CBenoit Jun 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: The query param is now specified as file_type=asciicast (even though the extension .cast)

}

impl RecordingFileType {
pub const fn as_str(self) -> &'static str {
match self {
RecordingFileType::WebM => "webm",
RecordingFileType::TRP => "trp",
RecordingFileType::Asciicast => "cast",
}
}
}
Expand Down