fix(jetsocat,dgw): allow bigger JMUX messages #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compatibility hazard: if a client sends a big message to an old Gateway, an error will be raised. First, we'll increase the maximum message size for Devolutions Gateway, and then we could increase the maximum size on client side in RDM in early 2025. |
awakecoding
approved these changes
Aug 14, 2024
CBenoit
force-pushed
the
perf/jmux-proxy-3
branch
3 times, most recently
from
828c996
to
3038012
Compare
This updates the decoder part of the JMUX codec. The intention is to increase the maximum message size for JMUX message in the future. By increasing the maximum size from 4k to 16k, an improvement of about 77.7% can be achieved when measuring using iperf. With 4k: > 0.0000-19.4523 sec 26.6 GBytes 11.7 Gbits/sec With 16k: > 0.0000-13.8540 sec 33.6 GBytes 20.8 Gbits/sec
CBenoit
force-pushed
the
perf/jmux-proxy-3
branch
from
3038012
to
5c8aa3b
Compare
CBenoit
changed the title
CBenoit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the decoder part of the JMUX codec.
The intention is to increase the maximum message size for JMUX message in the future.
By increasing the maximum size from 4k to 16k, an improvement of about 77.7% can be achieved when measuring using iperf.
With 4k:
With 16k: