fix: Cleanup a few things to make README better #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerinin
commented
Jan 31, 2024
| CMD ["uvicorn", "dewy.main:app", "--host", "0.0.0.0", "--port", "8000"] |
There was a problem hiding this comment.
Making this consistently 8000 everywhere, we can switch to a less-common port separately
|
|
||
| 1. Configure Dewy. | ||
| Dewy will read env vars from an `.env` file if provided. You can also set these directly | ||
| in the environment, for example when configuring an instance running in docker / kubernetes. |
There was a problem hiding this comment.
Using the .env config method, since this is running locally. Side note - do we want to make this something like ~/.dewyrc so the path isn't dependent on where you run the script?
| @@ -290,7 +290,7 @@ def encode_chunk(c: str) -> str: | |||
| WHERE id = $1 | |||
| """, | |||
| document_id, | |||
| extracted.text, | |||
| encode_chunk(extracted.text), | |||
There was a problem hiding this comment.
This caused a failure, since we're capturing the extracted doc content now.
bjchambers
approved these changes
Jan 31, 2024
kerinin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.