Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show the document body and associated chunks in a (new) document show… #49

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

kerinin
Copy link
Contributor

@kerinin kerinin commented Jan 31, 2024

… view.

@kerinin kerinin changed the title Show the document body and associated chunks in a (new) document show… feat: Show the document body and associated chunks in a (new) document show… Jan 31, 2024

const url = `${apiUrl}/api/${resource}?${stringify(queryparams)}`;
const { json, headers } = await httpClient(url);
return {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the document body will only be shown (1) on a get request and (2) after ingestion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine - if there's no body it will just be empty. We could show a snippet in the list view, I guess

@kerinin kerinin merged commit e880cb7 into main Jan 31, 2024
4 of 5 checks passed
@bjchambers bjchambers added the enhancement New feature or request label Jan 31, 2024
@bjchambers bjchambers deleted the rm/show-doc-body branch February 2, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants