feat: SQL model for collections #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with this since it is outside the main API and let's me figure out the ORM and interaction with the API methods, etc.
bjchambers
commented
Jan 18, 2024
| @@ -19,6 +19,9 @@ class Config: | |||
| env_file = ".env" | |||
| env_file_encoding = "utf-8" | |||
|
|
|||
| DB: str = "sqlite:///database.db?check_same_thread=false" | |||
There was a problem hiding this comment.
This supports the databases that sql alchemy does (eg., postgres:/// or postgres+asyncpg:/// for async) which seems nice. Although it's worth noting right now that since this uses a local file, it is non-persistent (need to tweak docker compose to give this a volume).
bjchambers
commented
Jan 18, 2024
| @@ -114,7 +117,7 @@ def custom_generate_unique_id_function(route: APIRoute) -> str: | |||
| from a variety of sources -- documents, web pages, audio, etc. | |||
| """, | |||
| "servers": [ | |||
| {"url": "http://127.0.0.1:8000", "description": "Local server"}, | |||
| {"url": "http://localhost:8000", "description": "Local server"}, | |||
There was a problem hiding this comment.
Fixes a problem with CORS and the /docs site making calls.
bjchambers
changed the title
kerinin
approved these changes
Jan 18, 2024
That part is the: which let's me do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with this since it is outside the main API and let's me figure out the ORM and interaction with the API methods, etc.