Release v1.2.4 | Constructor overrides, concurrency safety and ready for v1.2.4 release. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…making it more readable and maintainable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MINOR BREAKING: Removed getter and setter for
profileinOpenRouteServiceclass. It is now final and can only be set via the constructordefaultProfileparameter. This system is more concurrency-safe. If it needs to be overridden at the API call level, that can anyway be done by passing inprofileOverrideto the respective API method.Ability to change baseUrl #17 | Made API more flexible by allowing constructor-based overrides in
OpenRouteServiceclass of:baseUrl, the default API Base URLclient, the HTTP Client being used to make the requestsdefaultProfile, the default openrouteservice profile being used to make the requests.Ternary operator null check replaced with the null-aware operator in Vroom and Optimization data models
Getting from name and vice versa is now done using a map internally, making it more readable and maintainable