Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected behavior if MIDI channel > 16 #34

Closed
DhrBaksteen opened this issue Nov 13, 2018 · 1 comment
Closed

Unexpected behavior if MIDI channel > 16 #34

DhrBaksteen opened this issue Nov 13, 2018 · 1 comment
Assignees
@DhrBaksteen
Labels
bug

Comments

@DhrBaksteen
Copy link
Owner

When a MIDI device uses a channel greater than 16 it will cause random instrument settings and volumes due to the sketch not checking channel bounds.

This has been seen when there are multiple USB MIDI devices connected.

ArduinoOPL2/examples/Teensy/TeensyMidi/TeensyMidi.ino

Line 125 in 24c8199

void onNoteOn(byte channel, byte note, byte velocity) {

@DhrBaksteen DhrBaksteen self-assigned this Nov 13, 2018
DhrBaksteen added a commit that referenced this issue Nov 18, 2018
@DhrBaksteen
MIDI fixes for Teensy and Windows 3.1 instrument defs
89f52bb 
* This fixes issue #34 in TeensyMidi where MIDI events sent to a channel > 16 would cause unintended behavior such as random instrument changes and volumes.
* This fixes an issue in TeensyMidi where a volume control change change would cause channels to either go to minimum or maximum volume. Volme is now limited
to 80% to prevent instruments from clipping.
* Included the MIDI instrument definitions used in Windows 3.1 by to
SoundBlaster driver. These work best with MIDIs created for windows.
DhrBaksteen added a commit that referenced this issue Nov 18, 2018
@DhrBaksteen
MIDI fixes for Teensy and Windows 3.1 instrument defs
404fc2c 
* This fixes issue #34 in TeensyMidi where MIDI events sent to a channel > 16 would cause unintended behavior such as random instrument changes and volumes.
* This fixes an issue in TeensyMidi where a volume control change change would cause channels to either go to minimum or maximum volume. Volme is now limited
to 80% to prevent instruments from clipping.
* Included the MIDI instrument definitions used in Windows 3.1 by to
SoundBlaster driver. These work best with MIDIs created for windows.
@DhrBaksteen DhrBaksteen mentioned this issue Nov 18, 2018
Merged
@DhrBaksteen
Copy link
Owner Author

This one should now be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DhrBaksteen DhrBaksteen

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DhrBaksteen