Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle spaces in the job command arguments #90

Merged
merged 1 commit into from
Oct 23, 2024
Merged

handle spaces in the job command arguments #90

merged 1 commit into from
Oct 23, 2024

Conversation

thomasmfish
Copy link
Contributor

@thomasmfish thomasmfish commented Oct 17, 2024 •
edited
Loading

JobScheduler.make_job_submission: use shlex.join to handle spaces in the command

Tests are all passing

Fixes #89

@thomasmfish thomasmfish added the bug Something isn't working label Oct 17, 2024
@thomasmfish thomasmfish self-assigned this Oct 17, 2024
PeterC-DLS
PeterC-DLS approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thomasmfish thomasmfish marked this pull request as ready for review October 23, 2024 12:35
@thomasmfish thomasmfish merged commit 0fe732c into main Oct 23, 2024
4 checks passed
@PeterC-DLS PeterC-DLS deleted the handle-spaces-in-arguments branch October 23, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterC-DLS PeterC-DLS PeterC-DLS approved these changes

Assignees

@thomasmfish thomasmfish

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spaces in arguments aren't handled properly
2 participants
@thomasmfish @PeterC-DLS