Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Fix FGS system tests #13

Closed
DominicOram opened this issue Jan 20, 2022 · 3 comments
Closed

Fix FGS system tests #13

DominicOram opened this issue Jan 20, 2022 · 3 comments

Comments

@DominicOram
Copy link
Collaborator

Following the work done in https://gitlab.diamond.ac.uk/controls/python3/s03_utils/-/merge_requests/4 S03 is now reporting that twice the number of images than expected are being taken.

Acceptance Criteria

  • The code in the FGS system test that forces the expected images to be twice the expected is removed
  • System tests still work
This was referenced Jan 20, 2022
Merged
Merged
@DominicOram
Copy link
Collaborator Author

System tests inside gridscan may need updating to use latest versions of classes

@abbiemery
Copy link
Contributor

The Zebra and eiger system tests need updating and fixing too. The others pass when run with s03 working.

@abbiemery abbiemery mentioned this issue Sep 23, 2022
Closed
@d-perl
Copy link
Contributor

d-perl commented Jan 20, 2023

this is described in more detail by other open issues

@d-perl d-perl closed this as completed Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DominicOram @abbiemery @d-perl