This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Mxgda 3733: Minimal gridscan plan #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this code is merged delete https://github.com/DiamondLightSource/python-artemis/tree/test_minimal_scan |
bentom08
suggested changes
Jan 26, 2022
src/artemis/fast_grid_scan_plan.py
Outdated
| exposure_time=0.1, | ||
| acquisition_id="test", | ||
| directory="/tmp", | ||
| prefix="file.h5", |
There was a problem hiding this comment.
If, as I assume, these are intended as example parameters the file name extension should be removed, as it's incorrect and is added on by odin anyway
bentom08
approved these changes
Feb 10, 2022
DominicOram
added a commit
to DiamondLightSource/dodal
that referenced
this pull request
Aug 31, 2022
…urce/MXGDA_3733_minimal_gridscan_plan Mxgda 3733: Minimal gridscan plan NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
noemifrisina
pushed a commit
to DiamondLightSource/dodal
that referenced
this pull request
Jan 18, 2023
…urce/MXGDA_3733_minimal_gridscan_plan Mxgda 3733: Minimal gridscan plan NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
noemifrisina
pushed a commit
to DiamondLightSource/dodal
that referenced
this pull request
Feb 10, 2023
…urce/MXGDA_3733_minimal_gridscan_plan Mxgda 3733: Minimal gridscan plan NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
rtuck99
pushed a commit
that referenced
this pull request
Dec 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.diamond.ac.uk/browse/MXGDA-3733 and https://jira.diamond.ac.uk/browse/MXGDA-3765.
Note, is branched from #9 so merge that first.
To test:
pipenv run python src/artemis/fast_grid_scan_plan.py/tmp/bluesky.logand/tmp/ophyd.log