This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
fix zebra config to work on i03 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
suggested changes
Feb 4, 2022
There was a problem hiding this comment.
Looks good, I think we can go a bit further though:
- We should remove
LogicGateConfigurer.setup_fast_grid_scanandPositionCompare.setup_fast_grid_scan, they'll only cause future confusion as to why they're there. Arguably we can probably remove the whole classes but they might be useful in the future. - Now we're not using the position compare we can remove the arming/disarming in the stage/unstage. This will break the system tests so we'll have to fix them too
DominicOram
pushed a commit
to DiamondLightSource/dodal
that referenced
this pull request
Aug 31, 2022
…urce/fix_zebra_config fix zebra config to work on i03 NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
noemifrisina
pushed a commit
to DiamondLightSource/dodal
that referenced
this pull request
Jan 18, 2023
…urce/fix_zebra_config fix zebra config to work on i03 NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
rtuck99
pushed a commit
that referenced
this pull request
Dec 14, 2023
Establish dodal as primary project name over python-dodal
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17