Ensure records do not get stuck in processing state #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an exception occurs during an on_update callback, the "completion" function would never be called, which meant the PACT flag was never reset. This had the end result of causing the affected record to never process again, i.e. its value could never be changed.
Araneidae
approved these changes
Sep 19, 2024
coretl
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an exception occurs during an on_update callback, the "completion" function would never be called, which meant the PACT flag was never reset.
This had the end result of causing the affected record to never process again, i.e. its value could never be changed.
Also took the opportunity to add some protection to the cothread dispatcher against being passed and async function.
Fixes #170